Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frequency response function to Koopman pipeline #143

Merged
merged 10 commits into from
Aug 11, 2023
Merged

Add frequency response function to Koopman pipeline #143

merged 10 commits into from
Aug 11, 2023

Conversation

sdahdah
Copy link
Member

@sdahdah sdahdah commented Aug 11, 2023 •
edited
Loading

Resolves #142

Proposed Changes

  • Add KoopmanPipeline.frequency_response() to calculate Bode plot without actually plotting anything.

Checklist

  • Write unit tests
  • Add new estimators to existing scikit-learn compatibility tests
  • Write examples in docstrings
  • Update Sphinx documentation
  • Bump version number and date in setup.py, CITATION.cff, and
    README.rst

@sdahdah sdahdah added the enhancement New feature or request label Aug 11, 2023
@sdahdah sdahdah added this to the v1.1.4 milestone Aug 11, 2023
@sdahdah sdahdah self-assigned this Aug 11, 2023
@sdahdah sdahdah linked an issue Aug 11, 2023 that may be closed by this pull request
Add frequency response to Koopman pipeline #142
Closed
@sdahdah sdahdah merged commit d04328d into main Aug 11, 2023
5 checks passed
@sdahdah sdahdah deleted the feature/142-add-frequency-response-to-koopman-pipeline branch August 11, 2023 20:49
@sdahdah sdahdah modified the milestones: v1.1.4, v1.2.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdahdah sdahdah

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Add frequency response to Koopman pipeline
1 participant
@sdahdah