Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate gitlab runners metrics #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oussemos
Copy link
Contributor

Give the possibility to activate metrics on gitlab runners

Docs: https://docs.gitlab.com/runner/monitoring/README.html

@oussemos oussemos force-pushed the activate-metrics-gitlab-runner branch from e7a6dad to de2bf30 Compare December 15, 2017 15:49
@oussemos oussemos force-pushed the activate-metrics-gitlab-runner branch from de2bf30 to 220f711 Compare December 15, 2017 15:52
@drybjed
Copy link
Member

drybjed commented Dec 15, 2017

First of all, thanks for your PR! However, can you do it against the debops/debops repository? The roles will be exported from there in the future.

You should describe what each variable does as a separate section, that way they are better presented in the documentation.

In this case the Prometheus server connects to the Runners over TCP, correct? Is the traffic secured somehow? Since daemon listens over the network for external connections, that will require configuration for the debops.ferm role to open the port in the firewall. Registering the TCP port in /etc/services database using debops.etc_services role would also be nice.

If you don't plan to add the above features yourself, open an issue instead - I'll get around to it, most likely after the holidays and New Year.

@oussemos
Copy link
Contributor Author

@drybjed Thank you your work on the debops project too! I'll open a new PR after (or maybe during) the holidays.

@drybjed
Copy link
Member

drybjed commented Dec 15, 2017

@oussemos You're welcome. :-) By the way, it would be nice if DebOps could set up Prometheus, so that GitLab Runner support for it could be properly tested. The prometheus package is in Debian, so it makes installation much easier. Perhaps you have a Prometheus Ansible role, or you plan to write it?

@oussemos
Copy link
Contributor Author

@drybjed
Copy link
Member

drybjed commented Feb 22, 2018

@oussemos Since you're interested in Prometheus, there's currently a work in progress PR with Prometheus support for DebOps. You could try it out and help with development. :-)

@oussemos
Copy link
Contributor Author

@drybjed I'll have a look into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants