-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate gitlab runners metrics #19
base: master
Are you sure you want to change the base?
Conversation
e7a6dad
to
de2bf30
Compare
de2bf30
to
220f711
Compare
First of all, thanks for your PR! However, can you do it against the You should describe what each variable does as a separate section, that way they are better presented in the documentation. In this case the Prometheus server connects to the Runners over TCP, correct? Is the traffic secured somehow? Since daemon listens over the network for external connections, that will require configuration for the If you don't plan to add the above features yourself, open an issue instead - I'll get around to it, most likely after the holidays and New Year. |
@drybjed Thank you your work on the debops project too! I'll open a new PR after (or maybe during) the holidays. |
@oussemos You're welcome. :-) By the way, it would be nice if DebOps could set up Prometheus, so that GitLab Runner support for it could be properly tested. The |
@drybjed I used this one https://github.com/cloudalchemy/ansible-prometheus |
@oussemos Since you're interested in Prometheus, there's currently a work in progress PR with Prometheus support for DebOps. You could try it out and help with development. :-) |
@drybjed I'll have a look into it :) |
Give the possibility to activate metrics on gitlab runners
Docs: https://docs.gitlab.com/runner/monitoring/README.html