Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drift from job scheduling #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brasie
Copy link

@brasie brasie commented Feb 1, 2019

This PR is to remove drift from job scheduling, by basing the next run time off the
last scheduled run time, instead of datetime.datetime.now().

One perhaps nice possibility this PR opens up is, since the next scheduled time would be based on the previous scheduled time, one could store and restore the .last_run between invocations of a schedule script to let it pick up from where it left off.

@coveralls
Copy link

coveralls commented Feb 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling ab44f6d on brasie:nodrift into 5aaed06 on dbader:master.

@lalinsky
Copy link

lalinsky commented Dec 7, 2019

Would very much like this merged.

Remove drift from job scheduling, by basing the next run time off the
last *scheduled* run time, instead of `datetime.datetime.now()`.

Additionally, `idle_seconds` is enforced to be non-negative, since it is
now possible for `next_run` to be just before `now()`.
@brasie
Copy link
Author

brasie commented Dec 14, 2020

I rebased this against current master in case it is still of interest... I think it would help with the sort of issue brought up in places like #144, #163, #174, #207, #307, #355

@marcelhohn
Copy link

Is there any update on this?

@tianzhuqiao
Copy link

Do we have plan to merge this? This makes more sense especially if the task takes long to run (and the running time may vary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants