Maven Central Migration - Library updates to fix build #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes commenting out setting items in fragment_recycler_view_data.xml to allow sample project to build
Remove sample app temporary fix - creating a new issue for this to keep scope to allowing build for maven central migration
barnhill
suggested changes
Mar 5, 2021
lauren2020
commented
Mar 10, 2021
| tools:listitem="@layout/recycler_simple_item" /> | ||
| <!-- app:items="@{items}" was causing build error, temporarily removed --> |
There was a problem hiding this comment.
This is to prevent a build error for the demo app, would like to move fix for demo app to a separate pr to not hold up general build fix for maven central migration
|
gradlepluginportal() may point to JCenter too. We need to eval if this is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #768
This PR updates outdated dependencies that were preventing the project from building and being moved to maven central.