-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ENHANCEMENT - YouTubeDL-Material - add UID/GID env options #598
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What the dev thinks the uid/gid is not relevant in this context. It needs to be set to either 0 for root, or the uid/gid for the ansible Nas user needs to be calculated and used. Depends on the desired behaviour.
In Ubuntu uid/gid 1000 is the first user added user, ie likely you, which is definitely not the right one.
@@ -9,6 +9,10 @@ youtubedlmaterial_dl_audio_directory: "{{ downloads_root }}/youtube/audio" | |||
youtubedlmaterial_dl_video_directory: "{{ downloads_root }}/youtube/video" | |||
youtubedlmaterial_dl_subscriptions_directory: "{{ downloads_root }}/youtube/subscriptions" | |||
|
|||
# uid / gid | |||
youtubedlmaterial_user_id: "1000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right to me.
@@ -9,6 +9,10 @@ youtubedlmaterial_dl_audio_directory: "{{ downloads_root }}/youtube/audio" | |||
youtubedlmaterial_dl_video_directory: "{{ downloads_root }}/youtube/video" | |||
youtubedlmaterial_dl_subscriptions_directory: "{{ downloads_root }}/youtube/subscriptions" | |||
|
|||
# uid / gid | |||
youtubedlmaterial_user_id: "1000" | |||
youtubedlmaterial_group_id: "1000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this
@@ -28,6 +28,8 @@ | |||
- "{{ youtubedlmaterial_port_http }}:17442" | |||
env: | |||
ALLOW_CONFIG_MUTATIONS: "true" | |||
UID: " {{ youtubedlmaterial_user_id }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unintentional whitespace next to the uid/gid opening quotes
What this PR does / why we need it:
YouTubeDL-Material - add UID/GID env options
Not sure if the container supported this when I first added this to AN, but it does now. I left the defaults for UID/GID at the dev's defaults but now they can be overwridden.
Which issue (if any) this PR fixes:
Fixes #
Any other useful info:
I've had no success setting it to run as root:
It says "this is fine" but the container reboots. I have not tried setting to other UID's or GUD's, but now the option is there to play with. :->