-
Notifications
You must be signed in to change notification settings - Fork 69
Allow the ability to save the graph. #3
base: master
Are you sure you want to change the base?
Conversation
Limitations: Currently FF saves with incorrect image extension and the background of the image is transparent (will fix later).
Nice! Can you hold off for an hour or so, I'm trying to push a change that adds On Fri, Jul 11, 2014 at 7:25 PM, Simon Richardson notifications@github.com
|
Sure, no problems :) |
Do you want to pull #4 and resend this PR. Sorry for the crappy merge. |
I've added the ability to see what's the gc is doing in some sort of delayed fashion. Essentially we poll the |
@SimonRichardson i'm sorry for not replying earlier. If you are still interested in landing this PR, please fix the merge conflicts and I'll merge it for you. |
Perhaps this could be done with less code changes from the client-side like such: http://stackoverflow.com/questions/15616925/save-flot-graph-as-image? |
@tonglil if you want to fix the conflicts, I'll be happy to review this branch. |
Why not just cmd + p if you are using Mac and open it in Preview? |
This is a PR to fix #1, there are some limitations outlined bellow and I'll see if I can fix the transparent image later on.
Limitations: Currently FF saves with incorrect image extension and
the background of the image is transparent (will fix later).