Add tests for calculated obsCollection #1373
Conversation
| childPlaces, err = FetchChildPlaces( | ||
| ctx, store, metadata, httpClient, remoteMixer, ancestor, childType) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
We don't want to always fetch this since the obsCollection collection could already exists from BT cache.
| // If data is missing, attach empty child places. | ||
| for _, place := range childPlaces { | ||
| obsByEntity[place] = &pbv2.EntityObservation{} | ||
| } |
There was a problem hiding this comment.
feels like this should be part of Flume logic. Right now Flume does not return place with no data. This is a behavior discrepancy.
I actually think it makes sense to not have an entry for a child place if there is no data in all scenarios.
There was a problem hiding this comment.
Should I add this to the flume instead?
There was a problem hiding this comment.
I still don't think we should add places with no data. Imagine fetching cities in USA for a custom DC variable which has data for 10 places. That would have thousands of empty entries.
I think we should gvc and understand why the child places are needed..
The calculator uses a variable/entity to try and fetch the data for for the calculated response. Currently, for BT it will return no response for places with no data, so the calculator won't detect there's any missing variable/entity to compute |
|
update on this PR? @n-h-diaz |
This change also adds empty place responses for all the childPlaces, since the child places are needed by the calculator
This mirrors the response for other ObservationResponses where requested places without data are empty, but let me know if you'd like me to remove these