Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

Add support for Brave Browser and Waterfox Current #260

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

grahamperrin
Copy link

@grahamperrin grahamperrin commented Mar 1, 2020

Fixes #250 (hopefully).

This draft PR will almost certainly require corrections to code from people who are familiar with:

  • Brave Browser
  • Waterfox Current

– on:

  • Linux
  • macOS
  • Windows.

The commits here are based upon the patch with which @Sawyer07 opened #250.

Please note:

  • I'm not a developer
  • my everyday OS is FreeBSD-CURRENT, there's no port of Brave Browser or Waterfox Current
  • I don't have a Mac on which to test

– and so on, so there's guesswork by me in all three of the files.

Aiming to fix darktrojan#250

* focusing first on Linux
@grahamperrin grahamperrin changed the title Add support for Brave Browser Add support for Brave Browser and Waterfox Current Mar 1, 2020
Addition of `waterfox-current` re: darktrojan#250 (comment)
NB **some guesswork** because I don't have a Mac on which to test.
NB **much guesswork**: 

* I'm not a developer
* Microsoft Windows is complicated to me (I normally use FreeBSD-CURRENT)

– it will be good if someone else can test and correct this code.
@sebma
Copy link

sebma commented Aug 8, 2020

@grahamperrin Hi, I tried your modifications from your 7510cb2 commit, but it didn't do anything.

I had to replace Brave-Browser-Dev by Brave-Browser for the script to work :

$ ls -ld ~/.config/BraveSoftware/Brave-Browser-Dev
ls: cannot access /home/abcdxyzt/.config/BraveSoftware/Brave-Browser-Dev: No such file or directory
$ ls -ld ~/.config/BraveSoftware/Brave-Browser
drwx------ 1 abcdxyzt abcdxyzt 1056 mars  14 02:36 /home/abcdxyzt/.config/BraveSoftware/Brave-Browser/

@DeltaForCain
Copy link

I found a way to make it work with Waterfox on Windows:

  • open open_with_windows.py with an editor
  • edit line 78: Where it says Firefox, enter Waterfox (two entries here)
  • edit line 83: same as above, change from Firefox to Waterfox

Save, run as instructed, it should now work.

@grahamperrin
Copy link
Author

(This fell off my radar a few months ago, sorry. All suggestions/fixes welcome.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Brave Browser
3 participants