Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go build not needed for go run #897

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

emctl
Copy link
Contributor

@emctl emctl commented Aug 5, 2023

Description

As we use the go run app.go command, we do not need to prebuild (i.e go build .).
No code change.

Issue reference

N/A

Checklist

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

As we use the `go run app.go` command, we do not need to prebuild.

Signed-off-by: Eamonn Mc <8000237+emctl@users.noreply.github.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 6871a0d into dapr:master Sep 8, 2023
5 of 7 checks passed
@yaron2 yaron2 added this to the 1.12 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants