Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize x25519-dalek version 2 #554

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Jul 27, 2023

Now that curve25519-dalek version 4 has been released and I couldn't find any outstanding PRs/Issues can version 2 of x25519-dalek be released?

Also, can https://github.com/dalek-cryptography/x25519-dalek redirect to here? It's pretty confusing

@robjtede

This comment was marked as outdated.

@robjtede robjtede mentioned this pull request Aug 11, 2023
@rozbb
Copy link
Contributor

rozbb commented Aug 11, 2023

Can you rebase on latest main?

@rozbb
Copy link
Contributor

rozbb commented Aug 11, 2023

Actually I'll just merge. The clippy lints are fixed in main so it shouldn't break the build. If it does I'll fix it.

@rozbb rozbb merged commit 6dd17b2 into dalek-cryptography:main Aug 11, 2023
12 of 14 checks passed
@rozbb
Copy link
Contributor

rozbb commented Aug 11, 2023

Thank you for this! And good catch on the deprecated constructor

@elichai elichai deleted the x25519-v2 branch August 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants