Fix matchers for net fail #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how to fix the constructor matcher for the network failure benchmark. You may want to manually copy the changes over rather than merge this due to the messiness of Jupyter notebooks. A few notes:
you always have to have some parameters in an abstract message. e.g.
val construct_req = AbsMsg(CIExit, SubClassMatcher(Set("com.android.volley.toolbox.StringRequest"), ".*<init>.*", "consRequest"),TopVal::Nil)instead of justNilas the last argument. I will make a separate pull request to throw an appropriate error.The line numbers in this method are all wrong when Soot loads it so the Reachable query isn't behaving right. I swapped it to a
DisallowedCallinto work around this limitation.You had a typo. "com.android.volley.StringRequest" should be "com.android.volley.toolbox.StringRequest"