Improvements to DesiredComposedResources
and ObservedComposedResources
#23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This makes it possible to mutate struct values while iterating over the map of composed resources. I found myself naturally wanting to do this while writing a Function. e.g.:
I haven't made the same change for observed resources, since they're supposed to be read-only to a Function.
This PR also removes the
DesiredComposedResources
andObservedComposedResources
types. I found they were just obfuscating what the types actually were when I tried to use them.I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested