Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated project dependencies and fixed breaking changes from 'axum' and 'base64' deprecated API's #11

Merged

Conversation

dommyrock
Copy link
Contributor

@dommyrock dommyrock commented Aug 3, 2023

Since I saw there is an open issue for dependency update I updated them to latest ones.
#10

I had to resolve few deprecated API's in code:

1 base64
Changelog
I had to update encode, decode API's.

2 axum
ContentLengthLimit has been removed
Changelog

Note: I had to temporary add #[axum_macros::debug_handler] to get to the actual error when removing ContentLengthLimit
multipart_macro_position

Demo: (Windows)
receive_qrsinc_windows

Linux build
I also checked out this branch to linux vm and managed to successfully build the project there.

NOTE This time I also bumped minor version to version = "0.2.4"

I hope dependabot will be happier now :)

@crisidev
Copy link
Owner

crisidev commented Aug 6, 2023

This is awesome and will close #10!

I was wondering if it would make sense to just release 0.3.0 instead of 0.2.4 as the dependency update is pretty drastic here..

@crisidev
Copy link
Owner

crisidev commented Aug 6, 2023

This is awesome and will close #10!

I was wondering if it would make sense to just release 0.3.0 instead of 0.2.4 as the dependency update is pretty drastic here..

Yeah, I think I'll merge the PR and release 0.3.0

@crisidev crisidev merged commit f828c62 into crisidev:main Aug 6, 2023
2 checks passed
crisidev added a commit that referenced this pull request Aug 6, 2023
* Remove clap in favor of argh, which removes ~20 dependencies
* Adapt the Axum code, remove Extensions in favor of pure state
  * #11
* Better error managemenent with custom HTML reporting

Signed-off-by: Bigo <1781140+crisidev@users.noreply.github.com>
@dommyrock
Copy link
Contributor Author

Seems good 👍
Thanks for merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants