Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: make lint workflow run on push and dispatch #54

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ee7
Copy link

@ee7 ee7 commented Feb 16, 2024

Previously, this workflow ran only on pull request.

Closes: #51

Previously, this workflow ran only on pull request.

Closes: #51
@ee7 ee7 requested a review from viega as a code owner February 16, 2024 18:26
@ee7 ee7 requested a review from miki725 February 16, 2024 18:39
@miki725
Copy link
Contributor

miki725 commented Feb 19, 2024

we can do this although officially the pre-commit workflow is no longer recommended and as its an open-source I switched it to pre-commit.ci which:

  • usually runs faster
  • will automatically send PRs bumping versions in pre-commit-config.yaml
  • if there are any issues in the PR will automatically fix them - see testing pre-commit.ci autofix #56 for example

as such I actually disabled the lint.yml in github right now. as pre-commit.ci cannot run things on merge/push, we could use remove pull_request from link.yml and use it for pushes on main and then use pre-commit.ci for the PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants