feat: Daemon mode #424
Open
feat: Daemon mode #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new base command; daemon Allows chalk to report over time (similar to exec) but without requiring a binary for chalk to exec Currently very slim but can be used as a jumping point to add c&c for other chalk instances
|
@miki725 Just FYI, approved the outside contribution to run tests, but seems to lead to some permissions issues; certainly none of the tests ran. |
viega
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
This all looks good, and definitely in line with work we need to be doing, so thanks for this.
I'm impressed you managed to figure out on your own some of the warts like the current need for the null section. Would be really happy to talk about where you wanted to take this next; we have a lot of options / thoughts.
In the meantime, I'm goof for this to merge myself. Definitely need to address the testing situation, and if Miro has feedback, ofc. But other than that, if it rebases cleanly, it's spot on for what we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif necessaryIssue
Related to #56
In order to have multiple chalk instances working together having a single chalk instance running in a dedicated daemon mode is a requirement. This is a first pass implementation of such a mode.
Description
Adds a daemon command that sets chalk into daemon mode. In daemon mode chalk will report on the host every
periodmilliseconds.This PR is simply a first pass implementation and future PRs will expand the functionality to set up a listening port that will allow other chalk instances to report to an instance running in daemon mode in order to batch chalk reporting
Testing
chalk daemonchalk daemon -p 10000