Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 128-bit DPD conversions #743

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Add 128-bit DPD conversions #743

merged 9 commits into from
Oct 1, 2024

Conversation

mborland
Copy link
Member

Closes: #741
Closes: #641

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

Project coverage is 99.1%. Comparing base (16712c0) to head (d55f599).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/dpd_conversion.hpp 87.4% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #743     +/-   ##
=========================================
- Coverage     99.2%   99.1%   -0.0%     
=========================================
  Files          226     226             
  Lines        16683   16751     +68     
  Branches      1802    1809      +7     
=========================================
+ Hits         16537   16596     +59     
- Misses         146     155      +9     
Files with missing lines Coverage Δ
include/boost/decimal/bid_conversion.hpp 100.0% <ø> (ø)
include/boost/decimal/decimal128.hpp 98.1% <ø> (ø)
include/boost/decimal/decimal128_fast.hpp 97.6% <ø> (ø)
test/test_dpd_conversions.cpp 100.0% <100.0%> (ø)
include/boost/decimal/dpd_conversion.hpp 96.6% <87.4%> (-2.0%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16712c0...d55f599. Read the comment docs.

@mborland mborland merged commit 48e9a87 into develop Oct 1, 2024
65 checks passed
@mborland mborland deleted the dpd128 branch October 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

128 bit DPD conversions Add to_dpd and from_dpd
1 participant