Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #723

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix a typo #723

merged 1 commit into from
Aug 26, 2024

Conversation

jk-jeon
Copy link
Contributor

@jk-jeon jk-jeon commented Aug 24, 2024

Found in jk-jeon/dragonbox#66.

According to @tobybell, it appears to work even with UINT32_C but it's definitely a typo anyway.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (4554989) to head (d2105e4).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #723     +/-   ##
=========================================
- Coverage     99.1%   99.1%   -0.0%     
=========================================
  Files          229     229             
  Lines        16430   16430             
  Branches      1781    1781             
=========================================
- Hits         16277   16276      -1     
- Misses         153     154      +1     
Files Coverage Δ
...ude/boost/decimal/detail/remove_trailing_zeros.hpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4554989...d2105e4. Read the comment docs.

Copy link
Member

@mborland mborland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@mborland mborland merged commit 489e13b into cppalliance:develop Aug 26, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants