Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support to CUDA #717

Merged
merged 54 commits into from
Aug 12, 2024
Merged

Add basic support to CUDA #717

merged 54 commits into from
Aug 12, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Aug 1, 2024

No description provided.

@mborland
Copy link
Member Author

mborland commented Aug 2, 2024

Build errors should be fixed by: boostorg/math#1168

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (4bf4e48) to head (f3bbbb4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #717     +/-   ##
=========================================
- Coverage     99.1%   99.1%   -0.0%     
=========================================
  Files          230     230             
  Lines        16431   16432      +1     
  Branches      1779    1781      +2     
=========================================
- Hits         16279   16278      -1     
- Misses         152     154      +2     
Files Coverage Δ
include/boost/decimal/decimal32_fast.hpp 96.8% <100.0%> (ø)
include/boost/decimal/detail/apply_sign.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/fenv_rounding.hpp 100.0% <100.0%> (ø)
...lude/boost/decimal/detail/integer_search_trees.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/normalize.hpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf4e48...f3bbbb4. Read the comment docs.

@mborland
Copy link
Member Author

mborland commented Aug 2, 2024

Back to green now that upstream math is fixed

@mborland mborland changed the title Add basic support to CUDA and SYCL Add basic support to CUDA Aug 9, 2024
@mborland
Copy link
Member Author

mborland commented Aug 9, 2024

This gets add, sub, mul, and div working for decimal32_fast on CUDA. Many more PRs to follow I'm sure

@mborland
Copy link
Member Author

Upstream fixes to math have been merged. Will double back if there's any remaining failures but I expect there will not be.

@mborland mborland merged commit 8df12cd into develop Aug 12, 2024
29 of 63 checks passed
@mborland mborland deleted the real_cuda branch August 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant