Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal32 operator< without normalization in the general case #711

Merged
merged 10 commits into from
Jul 16, 2024

Conversation

mborland
Copy link
Member

No description provided.

@mborland
Copy link
Member Author

Provides ~20% improvement in comparison benchmarks for decimal32

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.1%. Comparing base (43c44e6) to head (e727f04).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #711     +/-   ##
=========================================
- Coverage     99.1%   99.1%   -0.0%     
=========================================
  Files          230     230             
  Lines        16339   16413     +74     
  Branches      1766    1781     +15     
=========================================
+ Hits         16191   16259     +68     
- Misses         148     154      +6     
Files Coverage Δ
test/random_decimal32_comp.cpp 100.0% <100.0%> (ø)
test/random_decimal32_math.cpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/comparison.hpp 99.1% <95.3%> (-0.9%) ⬇️
include/boost/decimal/decimal32.hpp 98.8% <88.5%> (-0.9%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c44e6...e727f04. Read the comment docs.

@mborland mborland linked an issue Jul 16, 2024 that may be closed by this pull request
@mborland mborland merged commit 2a17f6e into develop Jul 16, 2024
64 checks passed
@mborland mborland deleted the no_normal branch July 16, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can operator<(DecimalType lhs, DecimalType rhs) skip normalization?
1 participant