Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comparison operators for decimal32 and decimal32_fast #703

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

mborland
Copy link
Member

Closes: #702

New runtimes in the comp benchmarks are 0.776 for decimal32 and 0.809 for decimal32_fast.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (1ff2bbd) to head (ae22722).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #703     +/-   ##
=========================================
- Coverage     99.2%   99.2%   -0.0%     
=========================================
  Files          230     230             
  Lines        16290   16309     +19     
  Branches      1757    1767     +10     
=========================================
+ Hits         16146   16164     +18     
- Misses         144     145      +1     
Files Coverage Δ
include/boost/decimal/decimal32.hpp 99.8% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal32_fast.hpp 97.1% <100.0%> (+0.1%) ⬆️
include/boost/decimal/detail/comparison.hpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff2bbd...ae22722. Read the comment docs.

@mborland mborland merged commit c115908 into develop Jul 10, 2024
63 of 64 checks passed
@mborland mborland deleted the comp branch July 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve 32-bit comparisons
1 participant