Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove vscmatured packets #2372

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat!: remove vscmatured packets #2372

wants to merge 10 commits into from

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Oct 25, 2024

Description

Closes: #2281

Consumer-side changes for removal of VSCMaturedPackets (see ADR 018).

Also, it removes the consumer genesis transformation as not needed.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke requested a review from a team as a code owner October 25, 2024 08:24
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler labels Oct 25, 2024
@mpoke
Copy link
Contributor Author

mpoke commented Oct 25, 2024

e2e tests need to be fixed

insumity
insumity approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@insumity insumity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that I'm not familiar with the app/consumer/genesis.go removals (e.g., transformToNew) (cc @bermuell ).

@mpoke
Copy link
Contributor Author

mpoke commented Oct 28, 2024

@bermuell could you please fix the e2e tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insumity insumity insumity approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCMaturedPacket removal -- consumer-side changes
2 participants
@mpoke @insumity