Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean distribution logs (backport #2356) #2360

Merged
merged 1 commit into from
Oct 17, 2024
Merged

refactor: clean distribution logs (backport #2356) #2360

merged 1 commit into from
Oct 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2024

Description

Add a check to consumer distribution logic to return early when there are no rewards allocated.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
This is an automatic backport of pull request #2356 done by [Mergify](https://mergify.com).

@sainoe @mergify
refactor: clean distribution logs (#2356)
8415402 
* add check to remove logs

* remove wrong condition

(cherry picked from commit 4ec913b)
@mergify mergify bot requested a review from a team as a code owner October 17, 2024 10:08
@mergify mergify bot assigned sainoe Oct 17, 2024
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Oct 17, 2024
@mpoke mpoke merged commit e8d9826 into release/v6.2.x Oct 17, 2024
12 of 16 checks passed
@mpoke mpoke deleted the mergify/bp/release/v6.2.x/pr-2356 branch October 17, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

Assignees

@sainoe sainoe

Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpoke @sainoe