Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove usage of v1 errors from v2 #7528

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Oct 31, 2024

Description

Note: there are still some imports of channelv1 in v2:

> grep -rli "modules/core/04-channel/types"
types/tx.pb.go
keeper/keeper_test.go
keeper/keeper.go
keeper/msg_server.go

These are all related to using the ResponseResultType enum in V2. I think we should duplicate it to V2 too and get totally rid of v1 imports in v2. But I'd prefer doing so in a separate PR (assuming people agree)

closes: #7476


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Nov 1, 2024

@bznein bznein merged commit 3c47bd7 into feat/ibc-eureka Nov 1, 2024
65 checks passed
@bznein bznein deleted the bznein/7476/RemoveV1ErrorsFromV2 branch November 1, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants