Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Batch proof fn's #7486

Merged
merged 4 commits into from
Oct 23, 2024
Merged

refactor: remove Batch proof fn's #7486

merged 4 commits into from
Oct 23, 2024

Conversation

colin-axner
Copy link
Contributor

Description

ref cosmos/ics23#389
closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
64.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@colin-axner colin-axner added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 04bd787 Oct 23, 2024
70 of 71 checks passed
@colin-axner colin-axner deleted the colin/remove-batch-refs branch October 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants