imp: add 08-wasm to top level simapp #7471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
colin-axner
commented
Oct 16, 2024
| @@ -511,6 +556,7 @@ func NewSimApp( | |||
| // IBC light clients | |||
| ibctm.NewAppModule(tmLightClientModule), | |||
| solomachine.NewAppModule(smLightClientModule), | |||
| wasm.NewAppModule(app.WasmClientKeeper), // TODO(damian): see if we want to pass the lightclient module here, keeper is used in AppModule.RegisterServices etc | |||
There was a problem hiding this comment.
copied over from 08-wasm. Should I convert to an issue?
|
|
ah seems it won't be possible to split up this work, back to my original pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the 08-wasm module to the top level simapp. In a followup pr, I will remove the 08-wasm specific workflows, as the top level simapp should be reusable. In a pr after that, I will remove the binary logic in the 08-wasm module. The idea is that we should be able to build a single simapp for all our modules, even those with separate go.mod's, without introducing unnecessary dependencies into our individual go.mod releases
My only uncertainty with using a single binary, is building images for wasm tags. We need the workflow to take a branch, and build from there. Then updating the go version for a wasm release would mean bumping the simapp ibc-go version
ref: #7445
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.