Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update transfer cli docs #7113

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

crodriguezvega
Copy link
Contributor

Description

After merging #7090 I realised that docs should be updated...

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely caught!

docs/docs/02-apps/01-transfer/09-client.md Outdated Show resolved Hide resolved
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
@crodriguezvega crodriguezvega added this pull request to the merge queue Aug 21, 2024
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
61.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Merged via the queue into main with commit 60b9af6 Aug 21, 2024
71 of 73 checks passed
@crodriguezvega crodriguezvega deleted the carlos/update-transfer-cli-docs branch August 21, 2024 20:07
mergify bot pushed a commit that referenced this pull request Aug 21, 2024
* docs: update transfer cli docs

* Update docs/docs/02-apps/01-transfer/09-client.md

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
(cherry picked from commit 60b9af6)

# Conflicts:
#	docs/docs/02-apps/01-transfer/09-client.md
crodriguezvega added a commit that referenced this pull request Aug 22, 2024
* docs: update transfer cli docs (#7113)

* docs: update transfer cli docs

* Update docs/docs/02-apps/01-transfer/09-client.md

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
(cherry picked from commit 60b9af6)

# Conflicts:
#	docs/docs/02-apps/01-transfer/09-client.md

* remove docs

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants