Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores after releases #6966

Merged
merged 6 commits into from
Jul 29, 2024
Merged

chores after releases #6966

merged 6 commits into from
Jul 29, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

Opening as draft for now, should be merged after releases (v7.7.0, v8.4.0 and the 08-wasm releases) are published.

I assume that v8.2.x and v8.3.x will be retracted.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor

gonna fix markdown links shenanigans (hopefully)

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link checker was failing due to missing (now existing tags). left one comment which troubled me but rest lgtm

@@ -50,6 +50,13 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

<!-- markdown-link-check-disable-next-line -->
## [v0.4.0+ibc-go-v8.3-wasmvm-v2.0](https://github.com/cosmos/ibc-go/releases/tag/modules%2Flight-clients%2F08-wasm%2Fv0.4.0%2Bibc-go-v8.3-wasmvm-v2.0) - 2024-07-29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still tagged wasm with 8.3? 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's mighty unfortunate. But such stuff happens. We will just need to put out another tag

RELEASES.md Outdated Show resolved Hide resolved
@colin-axner
Copy link
Contributor

Clicking merge when ready, lets take your question @DimitrisJim elsewhere

@colin-axner colin-axner added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit f3a8dfe Jul 29, 2024
68 of 70 checks passed
@colin-axner colin-axner deleted the carlos/post-releases-chores branch July 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants