Fix broken _load_channel_shanks().
#41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
changed the title
_load_channel_shanks().
|
This would be great. So many probes are moving to multi-shank these days. |
|
Hi @rossant would you mind taking a look at this one too? cheers! |
|
Actually apologies @rossant some further testing shows the assumption that channel positions will contain 1 unique x-position per shank is wrong. Will convert to draft and have a think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Phy the
shentry on the ClusterView and SimilarityView table's is always zero. It seems this is because the files these were originally read from are not longer available. This PR reads them instead from thechannel_positions.npy.This may require re-running tests somewhere, please let me know if there any other considerations, I have not tested this past loading Phy and checking the
shcolumn now contains indices which match the shank with the largest loading for a unit.