added option to display calibration plot within expServer

[kevin-j-miller]

I've had this in my branch for a while, and Laura requested that I try and merge it into the regular branch. If you press 'k' in expServer, a plot will appear that shows the rigs current calibration curve and the date of last calibration. I tweaked this to work with the regular rig, and tested it with zredone.

[k1o0]

Great idea! I'll add a docstring, test and deal with missing calibrations

[k1o0]

What do you think about changing this to a 'v' and including the gamma calibrations in the display?

[kevin-j-miller]

That seems reasonable to me! I think the water calibration is the thing the techs look at the most, but making more information more accessible seems like a good thing.

[k1o0]

Great, I'll change it to 'v' and make an issue about adding other plots in the future.

[k1o0]

Is there a case where dateTime isn't a field? It's assumed to be there in other parts of the code...

[kevin-j-miller]

It was coming up for me, but I think it's an issue that's specific to some things I had done on my branch that re fixed now. I think in dev it's safe to assume dateTime will always be there if a calibration in.

[k1o0]

Okay, I removed the if statement because on master there would be an error thrown beforehand, here:

Rigbox/+hw/devices.m

Lines 54 to 57 in 7d6b601

	if isprop(sg,'Calibrations')
	[newestDate, ~] = max([sg.Calibrations.dateTime]);
	fprintf('\nApplying reward calibration performed on %s\n', datestr(newestDate));
	end

[kevin-j-miller]

This looks great! I love the idea of displaying the keyboard shortcuts too. I'd been thinking of printing out cheat-sheets and leaving them in the room, but this is much more elegant.

[k1o0]

@kevin-j-miller If everything looks good to you I'll merge.

[kevin-j-miller]

I just took a look using a rig. Two things weren't perfect: After displaying the calibration plot, the background went to black rather than grey, and also the help text was kind of hard to read (see below)

The first I think could be solved by just not changing the background color to begin with (lines 420 and 423) -- the plot displays as an image, so it's background will still be white, just not the psychtoolbox background behind it. The second I think just needs a smaller fontsize or larger line spacing.

[k1o0]

Hmm, that's weird. The background doesn't go black on my rig. It should return to whatever value bgColour is set to in expServer. Changing the background isn't so important be we should figure out why it goes black for you. Are you calling expServer with any inputs?

Regarding the text, it looks fine for me so I guess this depends on the resolution of the screen. Perhaps I should scale the font size by the vertical resolution?

By the way for testing I use hw.debugWindow.

[k1o0]

I looked into the text size setting. It seems PTB uses the system default, which should work fine. The clipping your seeing is not affected by the line spacing. In Windows Settings > System, is Scaling set to 100? Try running this code and telling me how it looks:

rig = hw.devices([], false);
win = rig.stimWindow;
win.open();

sz = 20;
def = Screen('TextSize', win.PtbHandle, sz);

msg = sprintf('Default text size: %.0f,\n current size: %.0f', def, sz);
win.drawText(msg, 'centerblock', 'center', win.White, 1, 40)
win.flip()
pause(5)

Screen('TextSize', win.PtbHandle, def);
win.close;

[k1o0]

I'm going to merge this into the branch for the next release, so I'm closing this PR.