Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify kernels for basic and nested affine for loop #204

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Unify kernels for basic and nested affine for loop #204

wants to merge 4 commits into from

Conversation

EthanMeng324
Copy link

Create a MLIR level unify functionality for two kernels. Merge the same affine for loop and use conditional branch to support different logic.

Migrate from an unmerged PR in hcl-dialect: cornell-zhang/hcl-dialect#217

chhzh123
chhzh123 reviewed Sep 28, 2024
View reviewed changes
Copy link
Member

@chhzh123 chhzh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As now the dialect and the frontend have been merged, can you also add the Python tests under the tests folder?

mlir/lib/Transforms/UnifyKernels.cpp Outdated Show resolved Hide resolved
@chhzh123
Copy link
Member

@EthanMeng324 Can you follow this guide to format your code and add necessary headers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhzh123 chhzh123 chhzh123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EthanMeng324 @chhzh123