Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable composefs for 41+ #2856

Closed
wants to merge 2,157 commits into from
Closed

Enable composefs for 41+ #2856

wants to merge 2,157 commits into from

Conversation

cgwalters
Copy link
Member

We really want to aim to eventually enable this by default, let's test things out in rawhide.

A thing that this is known to break is the "chattr -i" hack for new toplevel dirs (xref coreos/rpm-ostree#337 )

Basically if you want that, you either need to make a derived image, or enable transient root.

cgwalters and others added 30 commits November 9, 2023 17:42
- This removes the autoprune stuff which is already always on in ostree now
- Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
For a brief period of time during the release of a new
Fedora version, the latest tag may not point to a proper version and
this test will fail. Update the fedora-minimal image tag to be
version specific instead of latest to prevent test failures.
Adapt the test as per the changes from
coreos#2723
Now, we git grep from ostree-x.conf instead of
ostress-x-fedora-coreos.conf
This is so far the only test here which breaks when we're first
booted into a container.  rpm-ostree's own tests are *so*
not ready for this, but we can get to that later...
Also, kexec-tools 2.0.27 is now in F39 so
the kdump.crash is passing on production streams.
kdump.crash in rawhide for ppc64le, ext.config.docker.basic
and coreos.ignition.ssh.key are still failing
These tests are broken with the latest GRUB BOOTP binaries in cosa,
which is now on f39.
This is an easy way to save CI resources; when a PR is updated, abort
any previous build for that PR to focus on testing the latest push.
Explicitly include this sub package as we want to make sure that AMD CPU
microcode firmwares are included in FCOS, just like we include the ones
for Intel CPU.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2251053
Fixes: coreos/fedora-coreos-tracker#1618
In systemd commit b94f59b9d56 (part of v255+), the priority of the link
file generated from the `ifname` karg was changed from 90 to 70. We
don't really care about the priority here so just use a glob instead.

Fixes: coreos/fedora-coreos-tracker#1620
This reverts commit 077d418.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
This test has been failing on aarch64 builds. Let's denylist the
test while we work to find a fix for:
coreos/coreos-assembler#3669
Create a test to verify partition numbers and sizes. This is to ensure
that the partition scheme is what we expect during the transition to using
OSBuild in the FCOS pipeline.
The following tests are still failing as of today:
- `coreos.ignition.ssh.key`
- `ext.config.docker.basic`
- `ext.config.kdump.crash`

Extend the snooze on these tests for another two weeks while
we wait for a fix on them.
Triggered by remove-graduated-overrides GitHub Action.
s390x only has 2 partitions. Adjust the test accordingly.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
And also fix an issue where if an expected partition was missing
it will cause a syntax error, but the error wasn't caught. We catch
it now by checking if the start/size detected are "" before moving
forward.
coreosbot and others added 23 commits May 7, 2024 23:28
The postprocess bomb here went off this morning, which means we can
simplify this by a lot!
This test is still failing, but there's a PR open to resolve this.
Let's snooze for another week so we can land:
coreos/afterburn#1074
The `Before` key is undefined for the `Service` Section. This was
silentely ignored by systemd until systemd-v256-rc1 where it started
emmitting a log message :
`Unknown key name 'Before' in section 'Service', ignoring.`

This causes the pipeline to fail as kola consider this an error.
Saw a CI run timeout because `kdump.service` took 65s to build its
initramfs but we only wait 60s. Let's just bump this to have a larger
margin of error.
- Add "CoreOS" to the beginning of coreos-unique-boot.service
- Add "Ignition" to the coreos-ignition-unique-boot.service
    - This is an attempt to distinguish it from the other
- Change `boot` to Boot since that difference wasn't significant
…oot-uuid

We always set the metadata_csum_seed option on the ext4 filesystems
now so let's remove the conditional logic from the code.
We really want to aim to eventually enable this by default, let's
test things out in rawhide.

A thing that this is known to break is the "chattr -i" hack
for new toplevel dirs (xref coreos/rpm-ostree#337 )

Basically if you want that, you either need to make a derived image,
or enable transient root.
@jbtrystram
Copy link
Contributor

I wanted to experiment with that so I rebased this patch and built a rawhide with it and it works as expected :

[core@cosa-devsh ~]$ findmnt /
TARGET SOURCE  FSTYPE  OPTIONS
/      overlay overlay ro,relatime,seclabel,lowerdir=/run/ostree/.private/cfsroot-lower::/sysroot/ostree/repo/objects,redirect_dir=on,metacopy=on

[root@cosa-devsh core]# ls -la /sysroot/ostree/boot.1/fedora-coreos/ae2957172d56a1da0d18a974fcc50b515d08ec0a6c231a1ef78975130e1228d6/0/
total 5652
drwxr-xr-x. 12 root root    4096 May 28 15:28 .
drwxr-xr-x.  3 root root     161 Aug  1  2022 ..
-rw-r--r--.  1 root root 5771264 Aug  1  2022 .ostree.cfs

@jlebon
Copy link
Member

jlebon commented May 29, 2024

Chatted with @jbtrystram about this. We can open a PR against the rawhide branch with this change just so CI can run against it properly. If all the issues have been ironed out, we can get this in.

@jbtrystram jbtrystram changed the base branch from testing-devel to rawhide May 29, 2024 15:02
@jbtrystram jbtrystram mentioned this pull request May 29, 2024
@jbtrystram
Copy link
Contributor

Closing this for #3009

@jbtrystram jbtrystram closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.