Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/root-reprovision: Query /sysroot, not / #2781

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

cgwalters
Copy link
Member

Prep for enabling composefs. This is the same issue as coreos/coreos-installer#1203

Prep for enabling composefs.  This is the same issue as
coreos/coreos-installer#1203
@cgwalters
Copy link
Member Author

Ah, CI failure looks like unrelated fallout:

[ 4.073776] ignition[1282]: files: createFilesystemsFiles: createFiles: op(3): Error fetching file "/sysroot/etc/NetworkManager/dispatcher.d/30-timesyncd": resource not found

Ah, I see https://github.com/eworm-de/networkmanager-dispatcher-timesyncd/raw/master/30-timesyncd ceased to exist. Because of eworm-de/networkmanager-dispatcher-timesyncd@bdeed3f presumably but that claims to have been committed years ago. Confusing.

Anyways, here is the peril of having our gating tests depending on random uncontrolled internet resources...

@dustymabe
Copy link
Member

Ah, CI failure looks like unrelated fallout:

[ 4.073776] ignition[1282]: files: createFilesystemsFiles: createFiles: op(3): Error fetching file "/sysroot/etc/NetworkManager/dispatcher.d/30-timesyncd": resource not found

Ah, I see https://github.com/eworm-de/networkmanager-dispatcher-timesyncd/raw/master/30-timesyncd ceased to exist. Because of eworm-de/networkmanager-dispatcher-timesyncd@bdeed3f presumably but that claims to have been committed years ago. Confusing.

Anyways, here is the peril of having our gating tests depending on random uncontrolled internet resources...

#2782

@dustymabe
Copy link
Member

Prep for enabling composefs

Worth noting that soon we will be switching to OSBuild for image builds, which may have implications here.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM

@cgwalters cgwalters merged commit 5411e88 into coreos:testing-devel Jan 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants