Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix terraform cluster init and yq@4 usage #315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paschdan
Copy link

@paschdan paschdan commented May 6, 2021

  • Please check if the PR fulfills these requirements
  • The commit message follows the conventional commits guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug Fix

  • What is the current behavior? (You can also link to an open issue here)

terraform hangs and waits for cloud-init to finish, which never happens, because the nodes can not be initialized correctly

  • What is the new behavior (if this is a feature change)?

terraform runs through and the cluster is provisioned

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

@paschdan
Copy link
Author

paschdan commented May 6, 2021

not sure, if this is not only a temporary fix, because the pinned versions may not be there in the future, or at least not those exact versions.

@paschdan paschdan changed the title fix: Fix terraform and yq fix: Fix terraform cluster init and yq@4 usage May 6, 2021
@paschdan
Copy link
Author

paschdan commented May 6, 2021

hint: this will be fixed in docker 20.10.4 maybe we could also just add an apt repo with a up to date docker.io version, or use newer amis, with more up to date packages

docker/cli#2958

@paschdan
Copy link
Author

paschdan commented May 6, 2021

i changed my mind about how to tackle this bug, and am using now packages from ubuntus upstream, which are more up2date

there was a bug instroduced in dockdr 20.10, which is solved in 20.10.4
the official apt repo docker.io has currently 20.10.2 running, where the
bug makes kubeadm preflight error out.
@paschdan paschdan marked this pull request as ready for review May 6, 2021 21:33
@paschdan paschdan requested review from jondkent, s-irvine and a team as code owners May 6, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant