Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volatile keyword to mount #17

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add volatile keyword to mount #17

merged 1 commit into from
Nov 21, 2023

Conversation

ericcurtin
Copy link
Collaborator

initoverlayfs is designed to be throwaway, the data need not be synced, the volatile keyword makes the boot faster, by not demanding sync. Tested on Raspberry Pi 4.

@rhatdan
Copy link
Member

rhatdan commented Nov 20, 2023

LGTM
@giuseppe FYI

@ericcurtin
Copy link
Collaborator Author

Yup I noticed this "volatile" was your kernel contribution @giuseppe .

We should probably have volatile on for other throwaway filesystems like:

rpm-ostree usroverlay

and

bootc usroverlay

also. There would be some performance savings there too (it should be added in a way that supports kernels without "volatile" support also I guess if it was to be added for usroverlay). Even though usroverlay typically isn't a performance critical use case, but who knows, for some people it might be?

Btw, I'm kind of assuming "volatile" made the RHEL 9 kernel in this PR @giuseppe @rhatdan ... Is that true? I tested this on Fedora.

@ericcurtin
Copy link
Collaborator Author

@giuseppe @rhatdan any other recommendations/options/etc. that you are aware of that make IO faster feel free to suggest by the way...

@giuseppe
Copy link
Member

volatile should be in RHEL 9.

Would it make sense to retry the mount command without volatile if mount(2) fails with EINVAL?

giuseppe
giuseppe approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericcurtin
Copy link
Collaborator Author

Added reattempt without "volatile" on EINVAL

@ericcurtin
Add volatile keyword to mount
736de68 
initoverlayfs is designed to be throwaway, the data need not be synced,
the volatile keyword makes the boot faster, by not demanding sync.
Tested on Raspberry Pi 4.

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
giuseppe
giuseppe approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2023

LGTM

@rhatdan rhatdan merged commit 5c7c62d into main Nov 21, 2023
1 of 2 checks passed
@ericcurtin ericcurtin deleted the volatile branch November 21, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@dougsland dougsland Awaiting requested review from dougsland dougsland is a code owner

@masneyb masneyb Awaiting requested review from masneyb masneyb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericcurtin @rhatdan @giuseppe