fix: matchspec build / version from brackets and string serialization #917
+212
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
changed the title
|
Interestingly in conda, it looks like brackets are always preferred (which is the inverse of what I did here). For example: We can easily match conda behavior here. We could also add the option to fail on this in strict mode and allow version / build only once in strict mode (or only allow duplication if the value is exactly the same?). |
|
That seems like a good approach! |
|
I implemented that strict parsing fails when encountering a key multiple times (in brackets, or outside brackets & inside brackets). |
baszalmstra
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were parsing brackets correctly, but we overrode it with
None.This fixes matchspecs like
foo * [build="*bla*"]For now this is no error when the build string is set twice (e.g.
foo * bar*[build="baz"]). I am not sure if we should treat that as an error (at least in strict mode?). Same goes for the version.cc @jaimergp thanks for discovering this today!