Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editable pypi packages #581

Merged

Conversation

baszalmstra
Copy link
Collaborator

Adds the editable field to pypi packages to indicate they are installed in editable mode.

@baszalmstra baszalmstra force-pushed the feat/editable_packages_in_lock_file branch from 3780b25 to 5f68db7 Compare March 25, 2024 10:18
@baszalmstra baszalmstra marked this pull request as ready for review March 25, 2024 16:00
@tdejager
Copy link
Collaborator

LGTM

@baszalmstra baszalmstra merged commit 103482e into conda:main Mar 28, 2024
14 checks passed
@baszalmstra baszalmstra mentioned this pull request Mar 28, 2024
baszalmstra added a commit that referenced this pull request Apr 2, 2024
## 🤖 New release
* `rattler`: 0.19.5 -> 0.19.6 (✓ API compatible changes)
* `rattler_conda_types`: 0.20.3 -> 0.20.4 (✓ API compatible changes)
* `rattler_lock`: 0.21.0 -> 0.22.0 (⚠️ API breaking changes)
* `rattler_virtual_packages`: 0.19.4 -> 0.19.5 (✓ API compatible
changes)
* `rattler_package_streaming`: 0.20.1 -> 0.20.2
* `rattler_repodata_gateway`: 0.19.4 -> 0.19.5
* `rattler_solve`: 0.20.3 -> 0.20.4
* `rattler_index`: 0.19.4 -> 0.19.5
* `rattler_shell`: 0.19.4 -> 0.19.5

### ⚠️ `rattler_lock` breaking changes

```
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field PypiPackageData.editable in /tmp/.tmpcIdzpM/rattler/crates/rattler_lock/src/pypi.rs:40
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `rattler`
<blockquote>

##
[0.19.6](rattler-v0.19.5...rattler-v0.19.6)
- 2024-03-30

### Other
- remove unused dependencies
([#585](#585))
</blockquote>

## `rattler_conda_types`
<blockquote>

##
[0.20.4](rattler_conda_types-v0.20.3...rattler_conda_types-v0.20.4)
- 2024-03-30

### Fixed
- matchspec empty namespace and channel cannonical name
([#582](#582))
</blockquote>

## `rattler_lock`
<blockquote>

##
[0.22.0](rattler_lock-v0.21.0...rattler_lock-v0.22.0)
- 2024-03-30

### Added
- editable pypi packages
([#581](#581))
</blockquote>

## `rattler_virtual_packages`
<blockquote>

##
[0.19.5](rattler_virtual_packages-v0.19.4...rattler_virtual_packages-v0.19.5)
- 2024-03-30

### Added
- proper archspec detection using archspec-rs
([#584](#584))
</blockquote>

## `rattler_package_streaming`
<blockquote>

##
[0.20.2](rattler_package_streaming-v0.20.1...rattler_package_streaming-v0.20.2)
- 2024-03-30

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_repodata_gateway`
<blockquote>

##
[0.19.5](rattler_repodata_gateway-v0.19.4...rattler_repodata_gateway-v0.19.5)
- 2024-03-30

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_solve`
<blockquote>

##
[0.20.4](rattler_solve-v0.20.3...rattler_solve-v0.20.4)
- 2024-03-30

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_index`
<blockquote>

##
[0.19.5](rattler_index-v0.19.4...rattler_index-v0.19.5)
- 2024-03-30

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_shell`
<blockquote>

##
[0.19.5](rattler_shell-v0.19.4...rattler_shell-v0.19.5)
- 2024-03-30

### Other
- updated the following local packages: rattler_conda_types
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: Bas <4995967+baszalmstra@users.noreply.github.com>
Co-authored-by: Bas <4995967+baszalmstra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants