fix: allow not starts with in strict mode #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
approved these changes
Mar 21, 2024
Merged
tdejager
pushed a commit
that referenced
this pull request
Mar 22, 2024
## 🤖 New release * `rattler`: 0.19.4 -> 0.19.5 (✓ API compatible changes) * `rattler_conda_types`: 0.20.2 -> 0.20.3 (✓ API compatible changes) * `rattler_networking`: 0.19.2 -> 0.20.0 (⚠️ API breaking changes) * `rattler_lock`: 0.20.2 -> 0.21.0 (⚠️ API breaking changes) * `rattler_package_streaming`: 0.20.0 -> 0.20.1 * `rattler_repodata_gateway`: 0.19.3 -> 0.19.4 * `rattler_solve`: 0.20.2 -> 0.20.3 * `rattler_virtual_packages`: 0.19.3 -> 0.19.4 * `rattler_index`: 0.19.3 -> 0.19.4 * `rattler_shell`: 0.19.3 -> 0.19.4 ###⚠️ `rattler_networking` breaking changes ``` --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct constructible with a struct literal has a new non-public field. It can no longer be constructed using a struct literal outside of its crate. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/constructible_struct_adds_private_field.ron Failed in: field FileStorage.cache in /tmp/.tmpQ4WEef/rattler/crates/rattler_networking/src/authentication_storage/backends/file.rs:28 ``` ###⚠️ `rattler_lock` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/constructible_struct_adds_field.ron Failed in: field PypiPackageData.url_or_path in /tmp/.tmpQ4WEef/rattler/crates/rattler_lock/src/pypi.rs:22 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/inherent_method_missing.ron Failed in: Package::url, previously in file /tmp/.tmpSe8F94/rattler_lock/src/lib.rs:448 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_pub_field_missing.ron Failed in: field url of struct PypiPackageData, previously in file /tmp/.tmpSe8F94/rattler_lock/src/pypi.rs:22 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `rattler` <blockquote> ## [0.19.5](rattler-v0.19.4...rattler-v0.19.5) - 2024-03-21 ### Fixed - typo ([#576](#576)) </blockquote> ## `rattler_conda_types` <blockquote> ## [0.20.3](rattler_conda_types-v0.20.2...rattler_conda_types-v0.20.3) - 2024-03-21 ### Fixed - allow not starts with in strict mode ([#577](#577)) </blockquote> ## `rattler_networking` <blockquote> ## [0.20.0](rattler_networking-v0.19.2...rattler_networking-v0.20.0) - 2024-03-21 ### Fixed - implement cache for authentication filestorage backend ([#573](#573)) </blockquote> ## `rattler_lock` <blockquote> ## [0.21.0](rattler_lock-v0.20.2...rattler_lock-v0.21.0) - 2024-03-21 ### Added - allow passing pypi paths ([#572](#572)) </blockquote> ## `rattler_package_streaming` <blockquote> ## [0.20.1](rattler_package_streaming-v0.20.0...rattler_package_streaming-v0.20.1) - 2024-03-21 ### Other - updated the following local packages: rattler_conda_types, rattler_networking </blockquote> ## `rattler_repodata_gateway` <blockquote> ## [0.19.4](rattler_repodata_gateway-v0.19.3...rattler_repodata_gateway-v0.19.4) - 2024-03-21 ### Other - updated the following local packages: rattler_conda_types, rattler_networking </blockquote> ## `rattler_solve` <blockquote> ## [0.20.3](rattler_solve-v0.20.2...rattler_solve-v0.20.3) - 2024-03-21 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_virtual_packages` <blockquote> ## [0.19.4](rattler_virtual_packages-v0.19.3...rattler_virtual_packages-v0.19.4) - 2024-03-21 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_index` <blockquote> ## [0.19.4](rattler_index-v0.19.3...rattler_index-v0.19.4) - 2024-03-21 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_shell` <blockquote> ## [0.19.4](rattler_shell-v0.19.3...rattler_shell-v0.19.4) - 2024-03-21 ### Other - updated the following local packages: rattler_conda_types </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: Bas <4995967+baszalmstra@users.noreply.github.com> Co-authored-by: Bas <4995967+baszalmstra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562