-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run post-link scripts #574
Conversation
👍 One of the primary reasons that I am very much against executing scripts during installation is that it is a massive security risk. We are basically allowing arbitrary code execution at install time. Bun recently introduced the concept that a user has to explicitly allow running installation scripts for certain packages. Would you be open to adding a similar approach here right off the bat? I know this complicates the integration into rattler-build and pixi but I think its very important to protect users. |
89fc3f6
to
6ffc0e8
Compare
From our discussion:
To make things more secure in the longer run I advocate for:
I will make it configurable wether to run the installation scripts, and we can also emit a warningi or something like that/ |
8ce141e
to
09a7f93
Compare
fixes: