-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mirror handling and OCI mirror type #553
Conversation
Looks like some pushed artifacts have the wrong mediaType / no mediaType: pthread-stubs (https://github.com/orgs/channel-mirrors/packages/container/conda-forge%2Fosx-arm64%2Fpthread-stubs/23610821?tag=0.4-h27ca646_1001) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a bunch of comments.
- Would be nice if you can take a look at removing all unwraps or replacing them with expects.
- I think the API for the MirrorState contains lots of values that are unused. It would also be nice to type it a little more. There are some implicit expectations in there now, like that the URL is sort of rewritten, but this is completely unclear from comments and/or types.
- I think perhaps it would be nice to split this PR into two. One for the mirrors and one for OCI.
TODOs:
I think for this PR we shoudl fix the first item, but defer the other ones (and fix them in a little while when the OCI registry itself is fully functional). |
This is the start of the "mirror" implemnetation that would