Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unpin_decorators.patch file. #17

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

alanhdu
Copy link
Contributor

@alanhdu alanhdu commented Aug 22, 2022

Closes #16

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@alanhdu
Copy link
Contributor Author

alanhdu commented Aug 23, 2022

cc @hmaarrfk, since I think you also seem to be a maintainer / have merge-access?

(apologies for the ping if you don't).

@alanhdu
Copy link
Contributor Author

alanhdu commented Oct 4, 2022

cc @jakirkham @hmaarrfk -- is there anything I can do here to help get this merged in? Without this, the current version of moviepy on conda is broken.

@alanhdu
Copy link
Contributor Author

alanhdu commented Oct 6, 2022

@conda-forge-admin please rerender

@jakirkham
Copy link
Member

Thanks Alan! 🙏

It is worth noting that this is a Python 3 only package now, but AIUI this patch was for Python 2. Am wondering should we just drop the patch? Or is it still needed for some reason?

@alanhdu
Copy link
Contributor Author

alanhdu commented Oct 7, 2022

It is worth noting that this is a Python 3 only package now, but AIUI this patch was for Python 2. Am wondering should we just drop the patch? Or is it still needed for some reason?

I'm not an expert here, but IIUC ths patch correctly it's meant to allow moviepy to use decorator=5 (this seems to be a port of Zulko/moviepy#1565) -- I think that Python 2 builds are already skipped (see feffd3f where this was added), so I'm not sure we can drop the patch.

(I think the "root" problem is that moviepy hasn't cut a release in almost 2 years now, which is why some of the dependencies needed to get updated).

@jakirkham
Copy link
Member

Gotcha. Thanks for the context! 🙏

Yeah it seems they are working on it ( Zulko/moviepy#1089 ), but it is a big release, which would take time to get out.

@jakirkham jakirkham merged commit 26ac563 into conda-forge:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1.0.3 on conda-forge is broken
3 participants