Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start using inline-snapshot #1997

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

start using inline-snapshot #1997

wants to merge 2 commits into from

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Jul 29, 2024

Let's discuss! :)

@wolfv wolfv requested a review from a team as a code owner July 29, 2024 07:17
nichmor
nichmor reviewed Jul 29, 2024
View reviewed changes
tests/test_cli.py
assert data["bot"]["automerge"] is True
assert data["bot"]["run_deps_from_wheel"] is True

if data.get("conda_build_tool") == "rattler-build":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about using "rattler-build" value from conda_smithy.utils module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@wolfv
Copy link
Member Author

wolfv commented Jul 29, 2024

Benefits: updating snapshots is really easy and nice. Adding snapshot tests is also trivial.
Downside: the tests that I converted here are now more verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichmor nichmor nichmor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfv @nichmor