Add USDT market on ETH mainnet #827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
…h new Comet logics that will compare Comet's raw balance diff to credit user in accounting. Comet's always got 0 token, so comet always credit 0, thus it won't hit SupplyCapExceeded() error no more
…dded one test case to show the known vulnerability (re-entrance when token contract itself is eploited)
…th the risk of storage collision
…racts with the risk of storage collision" This reverts commit d0f016a.
This reverts commit 49588d6.
Address oz's feedback on USDT comet support
vincetiu8
force-pushed
the
franklindao/mainnet-usdt
branch
from
e09292a
to
876cd15
Compare
vincetiu8
changed the title
vincetiu8
force-pushed
the
franklindao/mainnet-usdt
branch
2 times, most recently
from
75fbae8
to
b621671
Compare
vincetiu8
force-pushed
the
franklindao/mainnet-usdt
branch
2 times, most recently
from
484f5fe
to
a99961f
Compare
contracts/Comet.sol
Outdated
| @@ -194,6 +194,8 @@ contract Comet is CometMainInterface { | |||
|
|
|||
| /** | |||
| * @dev Prevents marked functions from being reentered | |||
| * Note: this restrict contracts from calling comet functions in their hooks. | |||
There was a problem hiding this comment.
Nitpick: "restrict" should be "restricts"
vincetiu8
force-pushed
the
franklindao/mainnet-usdt
branch
from
ee3e5be
to
9b95900
Compare
vincetiu8
force-pushed
the
franklindao/mainnet-usdt
branch
from
3c3f204
to
c6127f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #818.
Copies market variables from mainnet USDC market.
Assets: