Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address OZ's feedback on USDT comet support #818

Merged
merged 36 commits into from
Feb 7, 2024
Merged

Address OZ's feedback on USDT comet support #818

merged 36 commits into from
Feb 7, 2024

Commits on Oct 30, 2023

  1. address L-02

    Hans Wang committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    369b363 View commit details
    Browse the repository at this point in the history

  2. use ethcall instead of assembly

    Hans Wang committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f7bf99a View commit details
    Browse the repository at this point in the history

  3. using low level call, so won't need IERC20Nonstandard as oppose for E… 

    …RC20.
    Hans Wang committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3544043 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. add reentrancy guard, and updated tests

    Hans Wang committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    85be018 View commit details
    Browse the repository at this point in the history

  2. address comments

    Hans Wang committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b2f8d03 View commit details
    Browse the repository at this point in the history

  3. inline nonReentrant call

    Hans Wang committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2c72dff View commit details
    Browse the repository at this point in the history

  4. update on tests

    Hans Wang committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    499dce8 View commit details
    Browse the repository at this point in the history

  5. intent

    Hans Wang committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    3d7fd01 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Update test/buy-collateral-test.ts 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    79ac88a View commit details
    Browse the repository at this point in the history

  2. Update test/supply-test.ts 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5ef9cfd View commit details
    Browse the repository at this point in the history

  3. Update test/withdraw-test.ts 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    6a936d1 View commit details
    Browse the repository at this point in the history

  4. Update test/withdraw-test.ts 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b3dbaa3 View commit details
    Browse the repository at this point in the history

  5. address comments

    Hans Wang committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ad99f2e View commit details
    Browse the repository at this point in the history

  6. add low level support to approveThis as well

    Hans Wang committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f2707f2 View commit details
    Browse the repository at this point in the history

  7. add bytes returndata to TransferOut/In() error, remove duplicated tests

    Hans Wang committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9ff7660 View commit details
    Browse the repository at this point in the history

  8. address comments, but now getting contract oversize :( both big contr… 

    …acts went over 24.576kb
    Hans Wang committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    41ee853 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. trim down a bit on contract size

    Hans Wang committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    8856e82 View commit details
    Browse the repository at this point in the history

  2. fix tests

    Hans Wang committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e6d6a86 View commit details
    Browse the repository at this point in the history

  3. fix lint

    Hans Wang committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9f770b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. use assembly for transfer action, as it save more spaces, and it's al… 

    …ready in-use in other contracts
    Hans Wang committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    46896c9 View commit details
    Browse the repository at this point in the history

  2. tests update

    Hans Wang committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9a33adc View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Add memory safe assembly

    Hans Wang committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f4df8a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. change reentrant to separate functions to reduce space

    Hans Wang committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d688672 View commit details
    Browse the repository at this point in the history

  2. address comments

    Hans Wang committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    99da5c4 View commit details
    Browse the repository at this point in the history

  3. add memory-safe as recommended in other palces

    Hans Wang committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    22830d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. address comments

    Hans Wang committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    53376ed View commit details
    Browse the repository at this point in the history

  2. lint

    Hans Wang committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    58d1df6 View commit details
    Browse the repository at this point in the history

  3. Update contracts/Comet.sol 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7d9dbe5 View commit details
    Browse the repository at this point in the history

  4. Update contracts/Comet.sol 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d45e8fe View commit details
    Browse the repository at this point in the history

  5. Update contracts/Comet.sol 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    b53c096 View commit details
    Browse the repository at this point in the history

  6. Update test/buy-collateral-test.ts 

    Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
    @cwang25 @kevincheng96
    cwang25 and kevincheng96 authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5c10dab View commit details
    Browse the repository at this point in the history

  7. address more comments

    Hans Wang committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d077e35 View commit details
    Browse the repository at this point in the history

  8. address comment to let new test to test on buyCollateral attacks spec… 

    …ifically
    Hans Wang committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    23cb021 View commit details
    Browse the repository at this point in the history

  9. evil token update

    Hans Wang committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    dd10703 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. remove accidently checked in test file

    Hans Wang committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    763f806 View commit details
    Browse the repository at this point in the history

  2. fix last two comments

    Hans Wang committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    68204da View commit details
    Browse the repository at this point in the history