Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in data copy name #1403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug in data copy name #1403

wants to merge 1 commit into from

Conversation

tomvanmele
Copy link
Member

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (166ac9d) to head (c194626).

Files with missing lines Patch % Lines
src/compas/data/data.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   60.70%   60.68%   -0.02%     
==========================================
  Files         207      207              
  Lines       22265    22266       +1     
==========================================
- Hits        13515    13512       -3     
- Misses       8750     8754       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.



def test_copy():
data = TestData()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you need to assign a name in your test before copying the object, in order the cover Line294. Otherwise it is just None, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem does not arise when a name is assigned, but when there isn't. when no name is assigned, the name attribute is not included in the serialisation info. however, (before this PR) when a copy is made the name attribute is assigned regardless. this means that the serialised info before and after copy don't match. that is what this PR fixes. the test as written, would have failed before this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants