Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compas_rhino.uninstall updated for ipy rhino8 #1383

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tetov
Copy link
Contributor

@tetov tetov commented Aug 7, 2024

Updated uninstall to match install, like here: cbe33b4

What type of change is this?

  • Bug fix in a backwards-compatible manner.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Comment on lines 43 to 49
if version == "8.0":
# In Rhino 8 there is no scripts folder
installation_path = compas_rhino._get_default_rhino_ironpython_sitepackages_path(version)
else:
# We install COMPAS packages in the scripts folder
# instead of directly as IPy module.
installation_path = compas_rhino._get_rhino_scripts_path(version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we perhaps do both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the goal of uninstalling is to remove all traces of packages, so perhaps we should try removing them from all possible locations...

@tomvanmele
Copy link
Member

@tetov can you add an entry in the CHANGELOG?

@tetov
Copy link
Contributor Author

tetov commented Oct 1, 2024

Updated to reflect @tomvanmele's comment above

In 642594f we now get:

$ python -m compas_rhino.uninstall -v 8.0
Uninstalling COMPAS packages from Rhino 8.0 scripts folders: 
['C:\\Users\\tetov/.rhinocode/py27-rh8/Lib/site-packages', 'C:\\Users\\tetov\\AppData\\Roaming\\McNeel\\Rhinoceros\\8.0\\scripts', 'C:\\Users\\tetov\\AppData\\Roaming\\McNeel\\Rhinoceros\\8.0\\Plug-ins\\IronPython (814d908a-e25c-493d-97e9-ee3861957f49)\\settings\\lib']

The following packages have been detected and will be uninstalled:       

   compas               OK
   compas_rhino         OK
   compas_ghpython      OK
   compas_bootstrapper  OK

Running post-uninstallation steps...

   compas_ghpython      OK: Uninstalled 5 GH User Objects

Uninstall completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants