Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTK pragma macros and fix "PythonQtInstanceWrapper.h" -Wold-style-cast warnings #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CTK pragma macros and fix "PythonQtInstanceWrapper.h" -Wold-style-cast warnings #837

wants to merge 1 commit into from

Commits on Oct 1, 2018

  1. Add CTK pragma macros and fix "PythonQtInstanceWrapper.h" -Wold-style… 

    …-cast warnings

The macros were adapted from ITK and allow to avoid warnings like the following:

/path/to/Slicer-build/CTK-build/CMakeExternals/Install/include/PythonQt/PythonQtInstanceWrapper.h: In member function ‘PythonQtClassInfo* PythonQtInstanceWrapperStruct::classInfo()’:
/path/to/Slicer-build/python-install/include/python2.7/object.h:115:49: warning: use of old-style cast [-Wold-style-cast]
 #define Py_TYPE(ob)             (((PyObject*)(ob))->ob_type)
                                                 ^
/path/to/Slicer-build/CTK-build/CMakeExternals/Install/include/PythonQt/PythonQtInstanceWrapper.h:68:37: note: in expansion of macro ‘Py_TYPE’
   {  return ((PythonQtClassWrapper*)Py_TYPE(this))->_classInfo; }
                                     ^
    @jcfr
    jcfr committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    f7335f6 View commit details
    Browse the repository at this point in the history