Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix error log filtering in ctkErrorLogWidget #1221

Merged
merged 1 commit into from
Sep 26, 2024
Merged

BUG: Fix error log filtering in ctkErrorLogWidget #1221

merged 1 commit into from
Sep 26, 2024

Conversation

Punzo
Copy link
Contributor

@Punzo Punzo commented Sep 26, 2024

Fix regression introduced in e9ef4c3

which made the error filtering buttons bugged.

@Punzo
Copy link
Contributor Author

Punzo commented Sep 26, 2024

@jcfr @lassoan

lassoan
lassoan approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, good catch! Q_DECLARE_FLAGS is always used with enums where each value is set to a single bit.

@lassoan lassoan merged commit d7ce6d9 into commontk:master Sep 26, 2024
4 checks passed
@Punzo Punzo mentioned this pull request Sep 26, 2024
Merged
@Punzo
Copy link
Contributor Author

Punzo commented Sep 26, 2024

Slicer PR at Slicer/Slicer#7964

@Punzo Punzo deleted the fixctkErrorLogWidget branch September 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Punzo @lassoan