Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to monero 0.18 #1100

Merged
merged 3 commits into from
Aug 11, 2022
Merged

feat: upgrade to monero 0.18 #1100

merged 3 commits into from
Aug 11, 2022

Conversation

delta1
Copy link
Collaborator

@delta1 delta1 commented Aug 9, 2022

Updates the docker images and wallet-rpc downloads to 0.18.0

closes #1081
fixes #1061

Copy link
Collaborator

@binarybaron binarybaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@binarybaron
Copy link
Collaborator

binarybaron commented Aug 10, 2022

Have you thought about implementing an auto updater? (Deleting the monero-wallet-rpc if it's not hardfork ready)

Manually updating the binary might be a bit inconvenient for regular users.

@delta1
Copy link
Collaborator Author

delta1 commented Aug 10, 2022

Yeah, I did want to try get that in with this. At the very least, check the version and alert the user, but preferably also delete the file and then get the new one.

- swap cli will check its wallet rpc version and delete the binary if
  its version does not match on "Fluorine Fermi". it will then download
  the newer version.
- adds download progress for wallet rpc
@delta1
Copy link
Collaborator Author

delta1 commented Aug 11, 2022

bors merge

bors bot added a commit that referenced this pull request Aug 11, 2022
1100: feat: upgrade to monero 0.18 r=delta1 a=delta1

Updates the docker images and wallet-rpc downloads to 0.18.0

closes #1081 
fixes #1061 

Co-authored-by: Byron Hambly <bhambly@blockstream.com>
@delta1
Copy link
Collaborator Author

delta1 commented Aug 11, 2022

bors cancel

action was stuck on retrieving cache

@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

Canceled.

@delta1
Copy link
Collaborator Author

delta1 commented Aug 11, 2022

bors merge

@bors bors bot merged commit fab87d9 into comit-network:master Aug 11, 2022
@delta1 delta1 deleted the monero-0.18 branch August 11, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants