Allow clipboard permissions in iframe preview #7545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I would say it's both a bug fix and a feature? Not sure.
What is the current behavior?
Currently, copying and pasting from the clipboard doesn't work in the preview iframe in the editor. This is because the preview frame is in another domain and some browsers (chrome and firefox for instance) block cross-origin access to the clipboard. Based on this article, the solution is to add the necessary permission to the
allow
attribute for the iframe. However, clipboard permissions are missing in the allow list.What is the new behavior?
Add
clipboard-read
andclipboard-write
to the preview frame to allow accessing the clipboard.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
clipboard-read
to the allow list of the iframe, and reload the iframe (it will not work without reloading).Checklist