Phase out the use of WSREP_KEY_SHARED key type in favour of WSREP_KEY_REFERENCE #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_REfERENCE (but keep support for it for backward compatibility) The only place where wsrep-lib made use of WSREP_KEY_SHARED is wsrep::append_sr_keys_for_commit() which is used only with protocols >= 4 so we don't need to worry about the protocol version and just change wsrep::key::shared to wsrep::key::reference. Refs #227
temeo
reviewed
Apr 6, 2024
| @@ -1960,7 +1960,7 @@ int wsrep::transaction::append_sr_keys_for_commit() | |||
| j(i->second.begin()); | |||
| ret == 0 && j != i->second.end(); ++j) | |||
| { | |||
| wsrep::key key(wsrep::key::shared); | |||
| wsrep::key key(wsrep::key::reference); | |||
There was a problem hiding this comment.
Reference key is probably too strong here. The purpose of adding shared keys to commit fragment is to create dependency, but changing it to reference key will create a conflict with exclusive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(but keep support for it for backward compatibility) The only place where wsrep-lib made use of WSREP_KEY_SHARED is wsrep::append_sr_keys_for_commit() which is used only with protocols >= 4 so we don't need to worry about the protocol version and just change wsrep::key::shared to wsrep::key::reference.
Refs #227